Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed telemetry event type and level to enums. #643

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Changed telemetry event type and level to enums. #643

merged 3 commits into from
Dec 20, 2024
+146 −130

Conversation

danielmorell
Copy link
Collaborator

@danielmorell danielmorell commented Dec 13, 2024 •
edited
Loading

Description of the change

There are two important components to this change.

  • It reduces the potential for errors by using enums for the telemetry event type and level.
  • It increases the minimum PHP version to 8.1 for the upcoming 4.1 release.

Note: PHP 8.0 stopped receiving security updates in November of 2023. So, it should be safe to drop support for new features like telemetry.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

None

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell added this to the v4.1.0 milestone Dec 13, 2024
@danielmorell danielmorell merged commit 5d78046 into master Dec 20, 2024
@danielmorell danielmorell deleted the changed/telemetry-event-type-and-level-to-enums branch December 20, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waltjones waltjones waltjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmorell @waltjones